Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[package:args] Added offset argument when throwing a ArgParserException. #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[package:args] Added offset argument when throwing a ArgParserException. #142

wants to merge 1 commit into from

Conversation

fa0311
Copy link
Contributor

@fa0311 fa0311 commented Oct 16, 2024

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Added offset argument when throwing a ArgParserException.

Continuation of dart-archive/args#285, dart-archive/args#283 (comment)

@fa0311
Added offset argument when throwing a ArgParserException.
0da04c4 
Signed-off-by: ふぁ <yuki@yuki0311.com>
@github-actions GitHub Actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
args None 2.6.1-wip 2.6.1-wip 2.6.1-wip ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage
pkgs/args/lib/src/allow_anything_parser.dart 💚 75 %
pkgs/args/lib/src/arg_parser.dart 💚 96 %
pkgs/args/lib/src/arg_parser_exception.dart 💚 50 %
pkgs/args/lib/src/parser.dart 💚 99 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package:args
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fa0311 @devoncarew